My sql Query string gives me error. I assume it has to do with the "where id= 80" par

[2939195631902]

My sql Query string gives me a error. I assume it has to do with the "where id= 80" part.



$game_info = get_table_data('games', 'id', 'ASC', 'rating', ' ', ''); // note there is a space between the second last set of single colons. So that it will trigger the function to add the where statement into the query.




// get all table data | Perform database query
function get_table_data($table, $order="id", $direction="ASC ", $column="*", $where="", $limit="") {
global $connection;
$query = "SELECT $column
FROM $table
ORDER BY $order $direction "; //must have space after $direction
if (!empty($where)) {
$query.="WHERE id = 80 "; //must have space after $limit. 80 is a example. I use it for testing the query.
if (!empty($limit)) {

$query.="LIMIT $limit ";

}
}
$table_set = mysql_query($query, $connection);
confirm_query($table_set);
return $table_set;
}

[Hades]

Note that you are placing the WHERE statement after the ORDER BY.

The query should look like:

SELECT ... 
FROM ... 
WHERE ...
ORDER BY ...

while yours looks like:

SELECT ... 
FROM ... 
ORDER BY ...
WHERE ...

I suggest you change the script into:

$query = "SELECT $column
FROM $table ";
if (!empty($where)) {
 $query.="WHERE id = 80 ";
}

$query .= " ORDER BY $order $direction ";

if (!empty($limit)) {
 $query.="LIMIT $limit ";
}

$table_set = mysql_query($query, $connection);
confirm_query($table_set);
return $table_set;

[2939195631902]

Originally Posted by Hades

Note that you are placing the WHERE statement after the ORDER BY.

The query should look like:

SELECT ... 
FROM ... 
WHERE ...
ORDER BY ...

while yours looks like:

SELECT ... 
FROM ... 
ORDER BY ...
WHERE ...

I suggest you change the script into:

$query = "SELECT $column
FROM $table ";
if (!empty($where)) {
 $query.="WHERE id = 80 ";
}

$query .= " ORDER BY $order $direction ";

if (!empty($limit)) {
 $query.="LIMIT $limit ";
}

$table_set = mysql_query($query, $connection);
confirm_query($table_set);
return $table_set;

I tried switching the Where and Order by, but it didn't work either.

Also, could i still integrate the code you suggested into a function like i have above.

[Hades]

can you either post the resulting query or the error that you get? maybe one of your variables is not set properly and the query produces an error.

[2939195631902]

Originally Posted by Hades

can you either post the resulting query or the error that you get? maybe one of your variables is not set properly and the query produces an error.

NVM i used ur code and figured out the rest.

Thx for your response!!