JavaScript is evil, I swear

Arenlor · 01-15-2007, 10:41 PM

Code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
   "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head><title>HIDDEN</title>
<link rel="icon" href="favicon.ico" type="image/x-icon" />
<link rel="shortcut icon" href="favicon.ico" type="image/x-icon" />
<meta http-equiv="content-type" content="text/html;charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<link rel="stylesheet" type="text/css" href="styles.css" /></head>
<body><form method="get" name="user" action="/forum/profile.php">
<select name="member_id" id="member_id" onChange="document.user.member_id.options[document.user.member_id.selectedIndex].value" ><option value="1">HIDDEN</option><option value="2">HIDDEN</option><option value="3">HIDDEN</option><option value=""></option><option value="5">HIDDEN</option><option value="6">HIDDEN</option><option value="7">HIDDEN</option><option value="8">HIDDEN</option><option value="9">HIDDEN</option><option value="10">HIDDEN</option></select></form><table class="forum">

<tr><td>Name:</td><td>HIDDEN</td></tr>
<tr><td>Address:</td><td>HIDDEN</td></tr>
<tr><td>Tele:</td><td>HIDDEN</td></tr>
</table><p><a href="profedit.php">Edit Profile</a></p><p><a href="index.php">Main</a></p>
</body>
</html>

As far as I know this should work so that when I select an option from the dropdown box it'll change the Name: Address: Tele: fields, I used PHP and MySQL for those fields, when I use a normal form, with a submit button it works fine, so I know it's not that part, it's only the change when an option is selected that's causing a problem. Also option 4 is meant to be missing.

StupidScript · 01-16-2007, 10:57 AM

Hmmm. It looks like the Javascript onchange event is telling your select element to adopt the value of ... whatever you selected in that element. There's no need for Javascript, here, that's default select element behavior. You haven't included anything else, so it doesn't do anything else.

Are you trying to execute an AJAX routine that populates the table values with values drawn from a db when the select element is changed? Your code as posted doesn't go far enough. The onchange event needs to trigger the AJAX routine. As it is, there's nothing wrong with this except the extraneous script.

All that aside, Javascript can seem pretty evil, at times.

Arenlor · 01-16-2007, 11:34 AM

I'm trying to do the type of thing they are trying to explain on this site http://www.netmechanic.com/news/vol3...cript_no12.htm I'm using PHP to populate the options, but I want to use Javascript to make it so that when I select the option the user doesn't have to use a submit button, it'll automatically change the page.

StupidScript · 01-16-2007, 04:55 PM

Oh, okay:

Code:

<select onchange="if (this.value) { top.location.href=this.value; }">
<option value=0 />Choose:
<option value="somepage.php" />Some Page
<option value="nextpage.php" />Next Page
<option value="lastpage.php" />Last Page
</select>

Similarly:

Code:

<script ...>
var pgs=new Array(null,"somepage.php","nextpage.php","lastpage.php");
</script>
<select onchange="if (this.value) { top.location.href=pgs[this.value]; }">
<option value=0 />Choose:
<option value=1 />Some Page
<option value=2 />Next Page
<option value=3 />Last Page
</select>

Badda bing!

Arenlor · 01-16-2007, 10:15 PM

I really don't like JS, I never learned it because I though I'd never need it, or use it either. The page is still not working even though I tried to fix it.

Code:

<select name="member_id" id="member_id" onChange="if (this.value) {top.location.href=profile.php?member_id=this.value;}"><option value="1">HIDDEN</option><option value="2">HIDDEN</option><option value="3">HIDDEN</option><option value=""></option><option value="5">HIDDEN</option><option value="6">HIDDEN</option><option value="7">HIDDEN</option><option value="8">HIDDEN</option><option value="9">HIDDEN</option><option value="10">HIDDEN</option></select></form>

Any suggestions?

StupidScript · 01-16-2007, 11:09 PM

Yep. A string is a string ...

Code:

onChange="if (this.value) {
 top.location.href=profile.php?member_id=this.value;
}"

should be

Code:

onChange="if (this.value) {
 top.location.href='profile.php?member_id='+this.value;
}"

Note the string delineators, the ' characters around the 'non-JSvariable' parts.

Go nuts! (And check out javascriptkit.com for some fundamentals.)

Arenlor · 01-17-2007, 01:54 AM

Whoot! It works, thanks a lot dude ^_^ I'll have to check out that site and start building my knowledge of JS up.