How to link javascript to an external file?

NameJunky · 01-23-2008, 01:23 PM

Hello all, I have a little bit of javascript in my index page and for SEO purposes I want to remove it from the index page and then link to it in an external file.

So this is what I have :

Code:

<script language="JavaScript" type="text/javascript">
<!--
function MM_swapImgRestore() { //v3.0
  var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;
}

function MM_preloadImages() { //v3.0
  var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
    var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
    if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}
}

function MM_findObj(n, d) { //v4.01
  var p,i,x;  if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
    d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);} 
  if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n]; 
  for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
  if(!x && d.getElementById) x=d.getElementById(n); return x;
}

function MM_swapImage() { //v3.0
  var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
   if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
}//-->
</script>

I cut all of that code and put it into a file and saved it as seoscript.js. Then I added this to my page:

Code:

<script src="seoscript.js"></script>

But now the javascript doesn't work. All it is is a rollover image script for the header links so it's not that big a deal, but it's just frustrating me! You can see what I mean by looking at my main page and hovering over the top links, and then look at the SEO page. The rollover images won't work on the SEO page.

Costin Trifan · 01-23-2008, 02:37 PM

there is definitely something wrong with that seo page. open it up in Firefox and form Tools menu item select Error Console and you'll find what's generating your error...

Are you loading the same images? because they doesn't look to be the same (comparing the index and the seo page)

nasty.web · 01-23-2008, 11:25 PM

Remove

Code:

<script language="JavaScript" type="text/JavaScript">
<!--

from the beginning.
And

Code:

//-->
</script>

from the end of your http://directorysubmissions.biz/seoscript.js.

Costin Trifan · 01-25-2008, 02:47 AM

roflmao... I've seen that before!