js function issue

[ag3nt42]

I'm trying to write a js function to complete two tasks with one event.

basically an onclick that checks to see if an img src is a specific pic then run actions based on that..below is my code which should give you an understanding of what i'm trying to accomplish... my problem i'm having is that the function will work the first time.. but not on the second click.

I would appreciate any advice somone can give.. ty

HTML

<div id='Alinkz'>
<div id='TCbox2'></div>
<div id='AlinkzDiv' style='height:15px;overflow:hidden;' onclick='switchArrows1();'>
EDIT MENU LINKS&nbsp;<img id='collapser1' src='imgs/arrowsdown.png' /><hr width='400px' />

<?php require('forms/Lkzform.php');?>

</div>
<div id='BCbox2'></div>
</div>

JS

function switchArrows1()
{
	if(document.getElementById("collapser1").src='imgs/arrowsdown.png')
	{
	document.getElementById("collapser1").src='imgs/arrowsup.png';
	document.getElementById("AlinkzDiv").style.height="100%";
	}
	else if(document.getElementById("collapser1").src='imgs/arrowsup.png')
	{
	document.getElementById("collapser1").src='imgs/arrowsdown.png';
	document.getElementById("AlinkzDiv").style.height="15px";
	}
	else
	{
	document.getElementById("collapser1").src='imgs/arrowsdown.png';
	}
}

[ag3nt42]

anyone?

[nasty.web]

if(document.getElementById("collapser1").src='imgs/arrowsdown.png')
...
else if(document.getElementById("collapser1").src='imgs/arrowsup.png')

I think there should be ==, JS comparison operator (not the assignment).

[ag3nt42]

tryed that doesn't seem to be working...

function switchIT()
{
	if(document.getElementById('collapser').src=='arrowsdown.png')
	{
	document.getElementById('AlinkzDiv').style.height="100%";
	document.getElementById('collapser').src="imgs/arrowsup.png";
	}
	else if (document.getElementById('collapser').src=='arrowsup.png')
	{
	document.getElementById('AlinkzDiv').style.height="15px";
	document.getElementById('collapser').src="imgs/arrowsdown.png";
	}
	else
	{
	alert('ERROR!!!! DUDE!!!');
	}
}

comes back everytime error

[nasty.web]

change the last alert into

alert('ERROR!!!! DUDE!!!'+document.getElementById('collapser').src);

and you'll see what the real collapser image path is.

[ag3nt42]

gives me the full path to the image...do i have to use the full path?

[ag3nt42]

wow talk about over killl its working if i use the fully path

thanx for the help nasty.. spose i'll setup a varible now for that long path name lol...

you think that js would be smart enough to just snatch the name of the file instead of treating it like a fully string.

works now tho..

[Boogle]

well no, if you think about it, the JS is only active one the page loads (or your HTTP state is 4)

so actually the Jscript is seiving through your full code and since the browserss renders your <img src="img1.jpg" /> to <img src="http://www.mysite.com/images/img1.jpg" /> then the Jscript sees "src='http://www.mysite.com/images/img1.jpg'" and not "src=img1.jpg" />

Make any sense?

Boog's

[ag3nt42]

yea it makes sense but you'd think that the JS writers would allow it to skip past the file path and recognize the file itself ya kno?

to make things simple for myself i ended up just throwing a variable in there that held the path information.