parse error at bottom of page

[robpicken]

Hi,

I've just set up a series of functions in a php script (there are going to be a few bugs to work out when i can get the page up), but i'm getting up a parse error at the bottom of the page, under the last line of code. I've spent ages trying to id the cause but can't find it. Anybody ideas why cause there to be a parse error on this particular line?

Thanks,

[hatchet]

Double and triple check your brackets.. there is probably one unbalanced.. the parse error comes up there because PHP is looking for it but can't find it.

[kwvarga]

or maybe a missing ; on the last function call

[fishfreek]

or delete any blank lines at the end of the file.

Some editors put junk at the end of the file. It shows up as an empty line but theres something there that screws up the script. Make sure their are no extra lines after your closing php tag.

[trevHCS]

Or if non of that works, try cutting each function out and call the script. If eventually it stops producing the error then you've narrowed it down.

As well as those mentioned, I'd also check for ) instead of } as it can be very hard to spot in some fonts.

Trev

[robpicken]

Hi,

Good News - I've fixed one of the pages that i was getting the error on. I had indeed missed out my final } on the very bottom line.

I'm still having problems with the other page though, and will prob do as trevHCS suggested and do a process of elimination until i find the problem.

Thanks for the help guys i'll post back the full results or code (if i can't fix it)

[robpicken]

Ok,

I've ripped the full page of code i did up, and put it all into seperate pages, that seemed to work. There were a few problems which i needed to fix and have done, however there is one problem that i just can't seem to work out.

The code below is identical to another bit of code that works. The problem is this bit doesn't I don't get up an error or a confirmation, i just get up a blank page when i try to delete the entry.

Anybody any ideas?

if (isset($_GET['deletefavourite'])) {
$favourite_id = $_GET['favourite_id'];
$sql = "DELETE FROM favourites WHERE favourite_id=$favourite_id";
if (mysql_query($sql)) {
echo('<p>Establishment has now been deleted from your favourites folder.</p>');
} else {
echo('Error ' . mysql_error() .'');
}
}

Many thanks, in advance

[hatchet]

[code:1:395938f310]$sql="DELETE FROM favourites WHERE favourite_id = '$favourite_id'";
$result=mysql_query($sql);
if(mysql_errno() != 0){
$msg = mysql_error();
}else{
$msg = urlencode("<p>Establishment has now been deleted from your favourites folder.</p>");
header("Location:index.php?msg=$msg");
}[/code:1:395938f310]
Could try doing it this way. And you wouldn't necessarily need the redirection.

[robpicken]

Hi,

Thanks for that, whilst i can play and rebuild existing php code all day, when it comes to writing something from scratch i'm still kinda new to it so get a bit lost.

I added in your new code, the only problem i had was that i had already sent headers, i can only guess it was with the php session thats running on that page. So i ended up with a Headers Already sent warning.

I removed the header that you added in, but ended up with the same problem, no message, and the listing not getting deleted.

[Jazzee]

Try using the entire code that hatchet gave you then make sure you have no blank lines at the very end of the pages like fishfreek said above.

[robpicken]

Silly Question do i keep the If (isset... so the code looks like this?

[code:1:3ecf05711d]if (isset($_GET['deletefavourite'])) {
$sql="DELETE FROM favourites WHERE favourite_id = '$favourite_id'";
$result=mysql_query($sql);
if(mysql_errno() != 0){
$msg = mysql_error();
}else{
$msg = urlencode("<p>Establishment has now been deleted from your favourites folder.</p>");
header("Location:index.php?msg=$msg");
}[/code:1:3ecf05711d]

Just incase i've messed up else were (although everything else works, the full code for that entire section is below:

[code:1:3ecf05711d]<?

//Code for viewing favourites

if (isset($_GET['viewfavourites'])) {
$sql_check = mysql_query("SELECT * FROM favourites WHERE username='$username'");
$sql_check_num = mysql_num_rows($sql_check);
if($sql_check_num == 0){
echo "You do not yet have any establishments in your favourite folder.";
} else {
$result = mysql_query("SELECT favourite_id, username, date_added, link_id, link_title FROM favourites WHERE username='$username'");
while ($row = mysql_fetch_array($result) ) {
$favourite_id = $row['favourite_id'];
$username = $row['username'];
$date_added = $row['date_added'];
$link_id = $row['link_id'];
$link_title = $row['link_title'];

// Include link to template

include 'view_favourites.html';
}

// Code to allow members to delete establishments from their favourite folder.

if (isset($_GET['deletefavourite'])) {
$sql="DELETE FROM favourites WHERE favourite_id = '$favourite_id'";
$result=mysql_query($sql);
if(mysql_errno() != 0){
$msg = mysql_error();
}else{
$msg = urlencode("<p>Establishment has now been deleted from your favourites folder.</p>");
header("Location:index.php?msg=$msg");
}
}
}
}
}
?>[/code:1:3ecf05711d]

Thanks the help is really appreciated [/quote]

[robpicken]

Hi Just thought i'd post back that i've fixed the problem. I re-wrote the php this morning, and altered a couple of lines as i was still getting headers already sent.

Thanks to all who helped, i've added the working code below, incase anybody is interested

[code:1:e06a21a168]if (isset($_GET['favouritedelete'])) {
$sql="DELETE FROM favourites WHERE favourite_id = '$favourite_id'";
$result=mysql_query($sql);
if(mysql_errno() != 0){
echo('Error ' . mysql_error() .'');
}else{
echo ('<p>Establishment has now been deleted from your favourites folder.</p>');
}[/code:1:e06a21a168]

[hatchet]

With header() it needs to be output before anything is rendered to the browser. So you probably have something output before the php is called. You can enclose everything in ob_start() and ob_flush() so it won't display that.
Glad you got it working though

[robpicken]

thanks hatchet,

I think I follow you, the ob_start() and ob_flush are familiar, although not 100% sure how they work even though i've worked with them in the past.

As i said in a previous post, i can re-write code all day long and put new code into existing php scripts, but the code i'd posted was part of a complete members area that i'd written myself, and if i get stuck with my own php creations i get really stuck! What i've created is probably not as good as some you can buy, but it works for me and works well (although i'll need to find a couple of people to test it first), besides it was a decent challenge, 3 days, 5 tables a dozen or so pages and integrated into WorldPay aswell so i'm happy. All i need to do now is create the admin area - but thats for another day...

Thanks for the help it was really appreciated ffom you all.

[hatchet]

The ob_* functions are output buffers. Where header runs into problems is it tries to interrupt what the browser is outputting already. ob_* saves all the information into a buffer and then can output it all at once while the other information is streaming also... that's as good as I can explain it anyway.. you get the idea.

[robpicken]

Thanks hatchet, i do follow you

Now for the next problem!

[code:1:d526e34e7d]if (isset($_GET['viewreviews'])) {
$sql_check = mysql_query("SELECT * FROM reviews WHERE username='$username' AND status='1'");
$sql_check_num = mysql_num_rows($sql_check);
if($sql_check_num == 0){
echo "Your Reviews folder is currently empty. If you have submitted a review, then it may not yet have been approved by a member of our reviews team.";
}[/code:1:d526e34e7d]

What i'm trying to do with the above code is only call up the reviews submited that have a status of 1 for that username. The way i have it now its calling up reviews that have a status of "0" (not approved) and "1" (approved) Thought i was getting smart with my "AND" statement too

Obviously not, well not yet. Any recommendations anybody?

[hatchet]

status = 1");
Remove the single quotes from around 1 - I'm sure your database has this field set to INT.

[hatchet]

You can also get rid of the == 0 by doing
if(!mysql_num_rows($sql_check) {
echo "your empty folder message"; } else {output rows code}
One less line to type

[robpicken]

Thanks again hatchet,

More Short Cuts!!!! lol I wish i'd posted half of this last week then i'd have saved a load of time! but also not had so much fun trying to correct my mistakes.

I'm still getting the same problem though even with the single quotes removed.

This is how my status field is set

status int(11) No 0

Guess that matches what you said

[hatchet]

Here's a similar function that I have for my affiliates. The only difference is you need to replace function tutcount with your if(isset(
Typically it will work with '' around variables so I don't think it's that.. take those off too just to make it similar.
My first question is.. I'm assuming you are searching for reviews made by a certain user ($username) and then I lose you.. are the reviews approved by you then for each user? So you essentially look for each user and a non-approved review?
If this function helps you any here it is.

[code]function tutcount($cat) {
$sql="SELECT * FROM tutorial WHERE cat = $cat AND status = 1";
$result=mysql_query($sql) or die("Could not connect");
if($tutnums=mysql_num_rows($result)) {
echo $tutnums;
} else {
$tutnums=0;
echo $tutnums;
}
}[\code]